Allow truth data to have smaller domain than prediction models in BMC#22
Merged
pabggpnMSU merged 6 commits intomainfrom Oct 14, 2025
Merged
Allow truth data to have smaller domain than prediction models in BMC#22pabggpnMSU merged 6 commits intomainfrom
pabggpnMSU merged 6 commits intomainfrom
Conversation
Co-authored-by: kylegodbey <5806808+kylegodbey@users.noreply.github.com>
…omains Co-authored-by: kylegodbey <5806808+kylegodbey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix common domain issues in BMC module
Allow truth data to have smaller domain than prediction models in BMC
Oct 10, 2025
Member
|
@copilot update the examples and the usage guide in the docs to reflect this behavior |
Co-authored-by: kylegodbey <5806808+kylegodbey@users.noreply.github.com>
Contributor
Author
Updated the documentation in commit COMMIT_HASH: Changes made:
The usage guide now clearly demonstrates:
|
Updated wording for clarity in usage documentation.
Removed the feature about flexible truth data from the documentation.
kylegodbey
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan to Fix Domain Intersection Issue ✅ COMPLETE
Problem: Currently,
load_data()uses an inner join on all models including the truth data, which forces the truth data to be present at all domain points. This unnecessarily restricts the model domains when truth data has a smaller domain.Solution: Modify
load_data()to:truth_column_nameto identify which model is the truth dataChanges completed:
Dataset.load_data()method signature to accepttruth_column_nameparameterDocumentation Updates:
Testing: All 29 tests pass, including:
Key Benefits:
✓ Truth data can have fewer domain points than models
✓ Train BMC on subset where truth is available
✓ Make predictions on full model domain
✓ Backward compatible - existing code works unchanged
✓ Works with both HDF5 and CSV formats
✓ Fully documented with examples
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.